[webkit-reviews] review granted: [Bug 131083] Rewrite Function.bind as a builtin : [Attachment 228926] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 131083: Rewrite Function.bind as a builtin
https://bugs.webkit.org/show_bug.cgi?id=131083

Attachment 228926: Patch
https://bugs.webkit.org/attachment.cgi?id=228926&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228926&action=review


r=me

This looks much better.

Please file a follow-up bug about performance of the .bind() case when extra
arguments are bound.

> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:815
> +    // Setting __proto__ of a primitive should have no effect.

This shouldn't say "__proto__".