[webkit-reviews] review granted: [Bug 131405] Add a WKNavigationAction property indicating whether it resulted from processing a user gesture : [Attachment 228905] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 131405: Add a WKNavigationAction property indicating whether it resulted
from processing a user gesture
https://bugs.webkit.org/show_bug.cgi?id=131405

Attachment 228905: Patch
https://bugs.webkit.org/attachment.cgi?id=228905&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228905&action=review


> Source/WebKit2/Shared/NavigationActionData.cpp:38
> +    , modifiers()

why?

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:41
>  @property (nonatomic, readwrite, copy, setter=_setOriginalURL:) NSURL
*_originalURL;
> + at property (nonatomic, readwrite, setter = _setUserInitiated:) BOOL
_userInitiated;

spaces or no spaces around the =? please choose.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:33
> + at property (nonatomic, readonly, getter = _isUserInitiated) BOOL
_userInitiated;

ditto