[webkit-reviews] review denied: [Bug 120120] [Windows] Generate Optimized WebInspectorUI in Release Build : [Attachment 228860] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied	review:
Bug 120120: [Windows] Generate Optimized WebInspectorUI in Release Build
https://bugs.webkit.org/show_bug.cgi?id=120120

Attachment 228860: Patch
https://bugs.webkit.org/attachment.cgi?id=228860&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228860&action=review


> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:107
> +    system($combineResourcesCmd, '--input-dir',
File::Spec->catdir('External', 'CodeMirror'), '--input-html',
File::Spec->catfile($derivedSourcesDir, 'Main.html'), '--input-html-dir',
$uiRoot, '--derived-sources-dir', $derivedSourcesDir, '--output-dir',
$derivedSourcesDir, '--output-script-name', 'CodeMirror.js',
'--output-style-name', 'CodeMirror.css');

On second look, the value to input-dir needs to be 'External/CodeMirror'. The
patch separator needs to always be "/" since that is how it is in the HTML.
This string is used for a regex and needs to match.