[webkit-reviews] review granted: [Bug 120120] [Windows] Generate Optimized WebInspectorUI in Release Build : [Attachment 228860] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 120120: [Windows] Generate Optimized WebInspectorUI in Release Build
https://bugs.webkit.org/show_bug.cgi?id=120120

Attachment 228860: Patch
https://bugs.webkit.org/attachment.cgi?id=228860&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228860&action=review


> Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.sh:46
> +if [[
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/CodeMirror.js" ]];
then
> +    export COMBINE_INSPECTOR_RESOURCES="YES";
> +fi

When would this kick in? This requires a build to already exist that has
combined resources/ What sets COMBINE_INSPECTOR_RESOURCES the first time?