[webkit-reviews] review granted: [Bug 131374] [Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element : [Attachment 228856] Add -[WKWebProcessPlugInNodeHandle isTextField]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 11:03:00 PDT 2014


Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 131374: [Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is
a text-type HTML input element
https://bugs.webkit.org/show_bug.cgi?id=131374

Attachment 228856: Add -[WKWebProcessPlugInNodeHandle isTextField]
https://bugs.webkit.org/attachment.cgi?id=228856&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228856&action=review


>
Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle
.h:45
> + at property (nonatomic, readonly, getter=isTextField) BOOL textField;

I think we should follow the pattern from JSValue here and make this a method
named isTextField instead of a property.


More information about the webkit-reviews mailing list