[webkit-reviews] review granted: [Bug 130570] Stylechecker: False positive on inline asm code. : [Attachment 228838] patch fix

[bugzilla-daemon at webkit.org]

Csaba Osztrogonác <ossy at webkit.org> has granted Gergő Balogh
<gbalogh.u-szeged at partner.samsung.com>'s request for review:
Bug 130570: Stylechecker: False positive on inline asm code.
https://bugs.webkit.org/show_bug.cgi?id=130570

Attachment 228838: patch fix
https://bugs.webkit.org/attachment.cgi?id=228838&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228838&action=review


Now it looks much better, r=me.

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2021
> -    if
search(r'^(?P<indentation>\s*)((explicit\s+)?[^(\s|\?)]+\([^\?]*\)\s?\:|^(\s|\?
)*\:)([^\:]|\Z)[^;]*$', line):
> +    is_list_start =
search(r'^(?P<indentation>\s*)((explicit\s+)?[^(\s|\?)]+\([^\?]*\)\s?\:|^(\s|\?
)*\:)([^\:]|\Z)[^;]*$', line)
> +    if is_list_start:

just a nit: do we really need this change? I don't think so.
Please change it back before landing.