[webkit-reviews] review denied: [Bug 130499] [CSS Regions] Monolithic elements should not affect the layout of the content outside its region : [Attachment 228843] Patch v3

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 130499: [CSS Regions] Monolithic elements should not affect the layout of
the content outside its region
https://bugs.webkit.org/show_bug.cgi?id=130499

Attachment 228843: Patch v3
https://bugs.webkit.org/attachment.cgi?id=228843&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Ok, so I finally understand why you need this code. The basic issue is that
regions have been improved to handle monolithic elements differently from
printing/columns. When a monolithic element overflows a region, you're actually
rendering the element entirely within the region it overflows. This is great,
and I wish printing and multicolumn behaved this way as well. I could use a
reminder of where the code lives that does this for when printing/multicolumn
change to behave like this in the future.

Anyway, I think we need a comment explaining that the reason this function
exists is because monolithic elements do not get split across regions, and note
that this is a difference from printing/multicolumn in the comment. The
function will also need to be tweaked to check for flow threads/regions, etc.
to make sure you don't turn this on for printing or multi-column (since right
now the gap makes sense for those systems).