[webkit-reviews] review granted: [Bug 122001] [GStreamer] Expose MPEG-TS metadata : [Attachment 228516] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 09:23:07 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 122001: [GStreamer] Expose MPEG-TS metadata
https://bugs.webkit.org/show_bug.cgi?id=122001

Attachment 228516: Patch
https://bugs.webkit.org/attachment.cgi?id=228516&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228516&action=review


> Source/WebCore/html/track/InbandDataTextTrack.h:48
> +    virtual void addDataCue(InbandTextTrackPrivate*, double, double, const
void*, unsigned) override;

Nit: please name the "start" and "end" variables.

> Source/WebCore/html/track/InbandTextTrack.h:65
> +    virtual void addDataCue(InbandTextTrackPrivate*, double, double, const
void*, unsigned) override { ASSERT_NOT_REACHED(); }

Ditto.

> Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h:137
> +    virtual void addDataCue(InbandTextTrackPrivate*, double, double, const
void*, unsigned) = 0;

Ditto.

>
Source/WebCore/platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStrea
mer.h:50
> +    void addDataCue(double start, double stop, const void* data, unsigned
length)

"stop" - do you mean "end"?


More information about the webkit-reviews mailing list