[webkit-reviews] review granted: [Bug 131343] [Cocoa] Add WKFormDelegate : [Attachment 228801] Add _WKFormDelegate
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 8 08:30:01 PDT 2014
Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 131343: [Cocoa] Add WKFormDelegate
https://bugs.webkit.org/show_bug.cgi?id=131343
Attachment 228801: Add _WKFormDelegate
https://bugs.webkit.org/attachment.cgi?id=228801&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228801&action=review
> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:145
> + NSObject <NSSecureCoding> *_userObject;
Please use a RetainPtr here.
> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1946
> - (void)_startAssistingNode:(const AssistedNodeInformation&)information
userObject:(NSObject <NSSecureCoding> *)userObject
I think you should rename this method.
More information about the webkit-reviews
mailing list