[webkit-reviews] review granted: [Bug 131208] Regression: AX: image labels no longer exposed to AX API in SVG test case : [Attachment 228805] patch

Mon Apr 7 23:20:20 PDT 2014

Daniel Bates <dbates at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 131208: Regression: AX: image labels no longer exposed to AX API in SVG
test case
https://bugs.webkit.org/show_bug.cgi?id=131208

Attachment 228805: patch
https://bugs.webkit.org/attachment.cgi?id=228805&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228805&action=review

This patch looks straightforward to me.

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1849
>  static String accessibleNameForNode(Node* node)

Nit: We should change the parameter type from Node* to Node& since this
function assumes node is a non-null pointer. Otherwise, we should check/assert
that node is non-null.

> LayoutTests/accessibility/svg-labelledby.html:6
> +<body id="body">

The HTML attribute id is unnecessary as we never reference this element by id
in this document. Moreover, it's sufficient it use document.body to obtain a
reference to the HTML Body element instead of assigning an id to it.

> LayoutTests/accessibility/svg-labelledby.html:13
> +  </path>

Nit: This closing tag has a different amount of indentation that its opening
tag (line 11).