[webkit-reviews] review denied: [Bug 131333] Build bmalloc on Mac : [Attachment 228798] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 131333: Build bmalloc on Mac
https://bugs.webkit.org/show_bug.cgi?id=131333

Attachment 228798: Patch
https://bugs.webkit.org/attachment.cgi?id=228798&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228798&action=review


It looks like you're missing the magic in the Xcode project itself that'll
actually set the optimization level / debug defines to the right values between
configurations:

				DEAD_CODE_STRIPPING =
"$(DEAD_CODE_STRIPPING_debug)";
				DEBUG_DEFINES = "$(DEBUG_DEFINES_debug)";
				GCC_OPTIMIZATION_LEVEL =
"$(GCC_OPTIMIZATION_LEVEL_debug)";
				STRIP_INSTALLED_PRODUCT =
"$(STRIP_INSTALLED_PRODUCT_debug)";

Those should be set in the Debug configuration at the project level. Take a
look at WTF's for comparison. Other than that, things look good!

> Source/bmalloc/Configurations/Base.xcconfig:88
> +HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include
$(DSTROOT)/$(INSTALL_PATH_PREFIX)/usr/local/include icu $(HEADER_SEARCH_PATHS);


I suspect you don't need these header search paths.

> Source/bmalloc/Configurations/Base.xcconfig:94
> +JAVASCRIPTCORE_FRAMEWORKS_DIR = $(SYSTEM_LIBRARY_DIR)/Frameworks;

Or this.