[webkit-reviews] review denied: [Bug 131319] Allow elements to register for changes in page scale : [Attachment 228773] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 131319: Allow elements to register for changes in page scale
https://bugs.webkit.org/show_bug.cgi?id=131319

Attachment 228773: Patch
https://bugs.webkit.org/attachment.cgi?id=228773&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228773&action=review


r- for the "moving between documents" issue.

> Source/WebCore/dom/Document.cpp:4199
> +void Document::registerForPageScaleFactorChangedCallbacks(HTMLMediaElement*
e)

e -> element.

> Source/WebCore/html/HTMLMediaElement.cpp:423
> +#if ENABLE(MEDIA_CONTROLS_SCRIPT)
> +    if (m_mediaControlsDependOnPageScaleFactor)
> +	   document().unregisterForPageScaleFactorChangedCallbacks(this);
> +#endif

What happens when an element moves between documents?

> Source/WebCore/html/HTMLMediaElement.cpp:5986
> +void HTMLMediaElement::setMediaControlsDependOnPageScaleFactor(bool v)

v -> something.

> Source/WebCore/page/Page.cpp:737
> +#if ENABLE(MEDIA_CONTROLS_SCRIPT)
> +    for (Frame* frame = &mainFrame(); frame; frame =
frame->tree().traverseNext())
> +	   frame->document()->pageScaleFactorChanged();
> +#endif

Don't we already do this somewhere, e.g. to tell compositing that the scale
changed?

Can this happen to pages in the page cache?