[webkit-reviews] review granted: [Bug 131325] [iOS WebKit2] WKPDFView fades in tiles, PDFs load very flashily : [Attachment 228769] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 131325: [iOS WebKit2] WKPDFView fades in tiles, PDFs load very flashily
https://bugs.webkit.org/show_bug.cgi?id=131325

Attachment 228769: patch
https://bugs.webkit.org/attachment.cgi?id=228769&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228769&action=review


> Source/WebKit2/UIProcess/Cocoa/WKWebViewContentProvider.h:38
>  // FIXME: This should be API.

I think you should extend this FIXME to say that we should come up with a
solution for the UIScrollViewDelegate “problem”.

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:134
> +	   if (CGRectIntersectsRect(pageInfo.frame, targetRect)) {

Please change this to

if (!CGRectIntersectsRect(pageInfo.frame, targetRect)) {
    [pageInfo.view removeFromSuperview];
    pageInfo.view = nullptr;
    continue;
}