[webkit-reviews] review granted: [Bug 131276] Move to using std::unique_ptr for opengl, texmap, transforms and efl in WebCore/platform/graphics. : [Attachment 228733] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Hyowon Kim <hw1008.kim at samsung.com>'s
request for review:
Bug 131276: Move to using std::unique_ptr for opengl, texmap, transforms and
efl in WebCore/platform/graphics.
https://bugs.webkit.org/show_bug.cgi?id=131276

Attachment 228733: Patch
https://bugs.webkit.org/attachment.cgi?id=228733&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228733&action=review


> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.h:39
> +    static std::unique_ptr<GraphicsContext3DPrivate>
create(GraphicsContext3D*, HostWindow*);

Not sure we really need this any more. Caller can just use make_unique.

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:119
> +    static std::unique_ptr<TextureMapper> create(AccelerationMode newMode =
SoftwareMode);

Argument name “newMode” should be deleted. Also, I don’t think we really need
this. Caller can just use make_unique.