[webkit-reviews] review requested: [Bug 131240] [Bindings] "nullable" sequence<T> support is incomplete : [Attachment 228758] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 7 14:25:48 PDT 2014


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 131240: [Bindings] "nullable" sequence<T> support is incomplete
https://bugs.webkit.org/show_bug.cgi?id=131240

Attachment 228758: patch
https://bugs.webkit.org/attachment.cgi?id=228758&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
I choose to add a bool parameter, named "acceptsNullable", to
JSDOMBindings::toNativeArray method, and set it to "true" from the generated
code upon the presence of "?" in the idl definition.

It might be that we should simply make toNativeArray to accept "null" arrays
always, similarly to toRefPtrNativeArray.

Please let me know.


More information about the webkit-reviews mailing list