[webkit-reviews] review granted: [Bug 130958] [EFL][WK1] Apply std::unique_ptr<> to NavigatorContentUtilsClientEfl : [Attachment 228715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 6 20:42:11 PDT 2014


Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 130958: [EFL][WK1] Apply std::unique_ptr<> to
NavigatorContentUtilsClientEfl
https://bugs.webkit.org/show_bug.cgi?id=130958

Attachment 228715: Patch
https://bugs.webkit.org/attachment.cgi?id=228715&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228715&action=review


> Source/WebKit/efl/ewk/ewk_view.cpp:867
> +    priv->navigatorContentUtilsClient = nullptr;

This line of code is not needed. Calling "delete priv" below will take care of
it.


More information about the webkit-reviews mailing list