[webkit-reviews] review granted: [Bug 131280] Rework CSS calc logic, fixing some reference count mistakes in Length : [Attachment 228701] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 131280: Rework CSS calc logic, fixing some reference count mistakes in
Length
https://bugs.webkit.org/show_bug.cgi?id=131280

Attachment 228701: Patch
https://bugs.webkit.org/attachment.cgi?id=228701&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228701&action=review


r=me

> Source/WebCore/css/CSSCalculationValue.h:94
> +    PassRef<CalculationValue> toCalcValue(const RenderStyle* currentStyle,
const RenderStyle* rootStyle, double zoom = 1.0) const;

This name seems a bit evil, since doing
someValue->toCalcValue().get().something(); would leak and assert.

> Source/WebCore/platform/Length.h:411
> +// FIXME: Is it really valuable to inline this?

I wonder if the compiler even bothers.

> Source/WebCore/rendering/style/RenderStyle.cpp:1357
>      case Auto:
>	   fontWordSpacing = 0;
> -	   FALLTHROUGH;
> +	   break;

Huh.