[webkit-reviews] review denied: [Bug 130958] [EFL][WK1] Apply std::unique_ptr<> to NavigatorContentUtilsClientEfl : [Attachment 228696] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 130958: [EFL][WK1] Apply std::unique_ptr<> to
NavigatorContentUtilsClientEfl
https://bugs.webkit.org/show_bug.cgi?id=130958

Attachment 228696: Patch
https://bugs.webkit.org/attachment.cgi?id=228696&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228696&action=review


> Source/WebKit/efl/ewk/ewk_view.cpp:-263
> -    OwnPtr<WebCore::NavigatorContentUtilsClientEfl>
navigatorContentUtilsClient;

This data member is still needed. It can be a std::unique_ptr, but we can’t
just get rid of it.

> Source/WebKit/efl/ewk/ewk_view.cpp:687
> +    WebCore::provideNavigatorContentUtilsTo(priv->page.get(),
std::make_unique<WebCore::NavigatorContentUtilsClientEfl>(smartData->self).get(
));

This is not going to work. It’s going to pass a pointer to
provideNavigatorContentUtilsTo after deleting the
NavigatorContentUtilsClientEfl object.