[webkit-reviews] review granted: [Bug 131184] Web Inspector: remove unused metrics and commands from the Timeline agent : [Attachment 228662] the patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 131184: Web Inspector: remove unused metrics and commands from the Timeline
agent
https://bugs.webkit.org/show_bug.cgi?id=131184

Attachment 228662: the patch
https://bugs.webkit.org/attachment.cgi?id=228662&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228662&action=review


> Source/WebCore/inspector/InspectorController.h:129
>      void willComposite();

This too isn't used.

> Source/WebCore/inspector/InspectorController.h:130
>      void didComposite();

Ditto.

> Source/WebCore/inspector/protocol/Timeline.json:-19
> -		   { "name": "usedHeapSize", "type": "integer", "optional":
true, "description": "Current size of JS heap." }

These should be removed from iOS 7 protocol files too.