[webkit-reviews] review denied: [Bug 131260] [EFL][WK2] Fix unused parameter compile warning : [Attachment 228663] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Miyoung Shin
<myid.m.shin at gmail.com>'s request for review:
Bug 131260: [EFL][WK2] Fix unused parameter compile warning
https://bugs.webkit.org/show_bug.cgi?id=131260

Attachment 228663: Patch
https://bugs.webkit.org/attachment.cgi?id=228663&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228663&action=review


> Source/WebKit2/ChangeLog:3
> +	   [EFL][WK2] Fix unused parameter compile warning.

This patch is not only for [EFL]. Please remove [EFL] prefix.

> Source/WebKit2/UIProcess/API/APIDownloadClient.h:51
> +    virtual void didReceiveData(WebKit::WebContext*, WebKit::DownloadProxy*,
uint64_t) { }

I prefer to use UNUSED_PARAM when parameter name is critical for clarity. In
this case, length is that case.

UNUSED_PARAM(length); ?

Besides there was a discussion how to handle unused parameter in below thread.
https://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html

> Source/WebKit2/UIProcess/API/APIDownloadClient.h:52
> +    virtual bool shouldDecodeSourceDataOfMIMEType(WebKit::WebContext*,
WebKit::DownloadProxy*, const WTF::String&) { return true; }

ditto.

> Source/WebKit2/UIProcess/API/APIDownloadClient.h:53
> +    virtual WTF::String
decideDestinationWithSuggestedFilename(WebKit::WebContext*,
WebKit::DownloadProxy*, const WTF::String&, bool&) { return { }; }

ditto.

> Source/WebKit2/UIProcess/API/APIDownloadClient.h:54
> +    virtual void didCreateDestination(WebKit::WebContext*,
WebKit::DownloadProxy*, const WTF::String&) { }

ditto.