[webkit-reviews] review requested: [Bug 131264] Frequent PluginProcess crashes at libsqlite3.dylib: openDatabase : [Attachment 228666] proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 131264: Frequent PluginProcess crashes at libsqlite3.dylib: openDatabase
https://bugs.webkit.org/show_bug.cgi?id=131264

Attachment 228666: proposed fix
https://bugs.webkit.org/attachment.cgi?id=228666&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
As a side effect, this will change plug-in NSURL cache location from
~/Library/Caches/com.apple.PluginProcess to
/var/folders/blah/blah/C/com.apple.PluginProcess for most users. CFNetwork uses
complicated logic to fall back to the latter if the former isn't appropriate
(namely, for network home directory users).

It doesn't make much sense to try replicating this logic, as we can just always
use the latter directory that works for everyone. CFNetwork behavior is of
course subject to change, so trying to approximate it is futile.

Perhaps we should have separate caches for different plug-ins (or even separate
them by UI process bundle identifier too), but this patch doesn't change this
aspect of the behavior.