[webkit-reviews] review granted: [Bug 131248] Date object needs to check for ES5 15.9.1.14 TimeClip limit : [Attachment 228638] patch 2: addressed MarkH's feedback.

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 131248: Date object needs to check for ES5 15.9.1.14 TimeClip limit
https://bugs.webkit.org/show_bug.cgi?id=131248

Attachment 228638: patch 2: addressed MarkH's feedback.
https://bugs.webkit.org/attachment.cgi?id=228638&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
Okay, so the answer is that we're not 100% sure that we'll do the right thing
always, but the test covers this particular bug. You should file a bug for us
to revisit this with a more comprehensive solution that probably involves
leveraging the type system in a creative way to make these sorts of bugs even
less likely.