[webkit-reviews] review granted: [Bug 131237] Use preallocated stack reference to store adjacentBacktrackingStart : [Attachment 228614] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 131237: Use preallocated stack reference to store adjacentBacktrackingStart
https://bugs.webkit.org/show_bug.cgi?id=131237

Attachment 228614: Patch
https://bugs.webkit.org/attachment.cgi?id=228614&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228614&action=review


Everything looks correct to me.  CQ- because of two nitpicks.

> Source/WebCore/cssjit/SelectorCompiler.cpp:210
> +    bool m_needsAdjacentBacktrackingStart : 1;

You should not use a bit field here.

I would put the field just after m_selectorFragments since it is related to a
global state of code generation.

> Source/WebCore/cssjit/StackAllocator.h:63
> +    StackReference push()

The name push() is a bit misleading. I think allocate() or
allocateUninitialized() would be better.