[webkit-reviews] review granted: [Bug 131050] Web Inspector: Provide a way for JSContext console to log to system console : [Attachment 228546] [PATCH] Revised

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 131050: Web Inspector: Provide a way for JSContext console to log to system
console
https://bugs.webkit.org/show_bug.cgi?id=131050

Attachment 228546: [PATCH] Revised
https://bugs.webkit.org/attachment.cgi?id=228546&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228546&action=review


> Source/JavaScriptCore/inspector/JSConsoleClient.cpp:75
> +    static std::once_flag initializeLogging;
> +    std::call_once(initializeLogging, []{
> +	   JSConsoleClient::initializeLogToSystemConsole();
> +    });

This makes the default behave differently than the WebKit2 equivalent setting.
It can only be changed between executions, not while the app is running. That
seems fine, but it might be limiting if an app needed to change it at runtime
(like with a command line flag or checkbox.) The solution would require always
calling CFPreferencesGetAppBooleanValue, or exposing a JSC API to change it at
runtime. We can cross that bridge when needed.