[webkit-reviews] review granted: [Bug 131211] [CSSRegions] Region's behaviour not updated when becoming valid from invalid : [Attachment 228579] Patch

[bugzilla-daemon at webkit.org]

Andrei Bucur <abucur at adobe.com> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 131211: [CSSRegions] Region's behaviour not updated when becoming valid
from invalid
https://bugs.webkit.org/show_bug.cgi?id=131211

Attachment 228579: Patch
https://bugs.webkit.org/attachment.cgi?id=228579&action=review

------- Additional Comments from Andrei Bucur <abucur at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228579&action=review


r=me

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:80
>      // If the region is not attached to any thread, there is no need to
check

You should consider removing this comment.

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:-511
> -    if (documentBeingDestroyed() || !m_flowThread)

Let's make a patch that removes the m_flowThread nullification as well. The
isValid() check should be enough.