[webkit-reviews] review granted: [Bug 131210] Fast-path for casting JS wrappers to JSElement. : [Attachment 228577] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 131210: Fast-path for casting JS wrappers to JSElement.
https://bugs.webkit.org/show_bug.cgi?id=131210

Attachment 228577: Patch
https://bugs.webkit.org/attachment.cgi?id=228577&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228577&action=review


> Source/WebCore/bindings/js/JSElementCustom.h:38
> +    return value.asCell()->type() >= JSElementType ?
JSC::jsCast<JSElement*>(value) : nullptr;

>= is a dangerous game.