[webkit-reviews] review granted: [Bug 131206] [Cocoa] Add additional WKWebView SPI for clients that interact with PDFs : [Attachment 228575] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 131206: [Cocoa] Add additional WKWebView SPI for clients that interact with
PDFs
https://bugs.webkit.org/show_bug.cgi?id=131206

Attachment 228575: Patch
https://bugs.webkit.org/attachment.cgi?id=228575&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228575&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1240
> +    return [reinterpret_cast<WKPDFView *>(_customContentView.get())
documentData];

We normally use C-style casts between Objective-C classes.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1247
> +    return [reinterpret_cast<WKPDFView *>(_customContentView.get())
suggestedFilename];

Ditto.

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:71
> +    _suggestedFilename = filename;

Please copy and adopt, since NSString has a mutable subclass.