[webkit-reviews] review granted: [Bug 131203] Crash in plugin process : [Attachment 228573] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 131203: Crash in plugin process
https://bugs.webkit.org/show_bug.cgi?id=131203

Attachment 228573: patch
https://bugs.webkit.org/attachment.cgi?id=228573&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

You should explain in your ChangeLog that the old code crashed because it the
C++ scope would delete its pluginController before the call to
pluginDidBecomeHidden.

Would it be better for this function to take a pluginInstanceID argument,
instead of a raw (dangerous) PluginControllerProxy pointer?