[webkit-reviews] review granted: [Bug 131196] Fast-path for casting JS wrappers to JSNode. : [Attachment 228567] Patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 131196: Fast-path for casting JS wrappers to JSNode.
https://bugs.webkit.org/show_bug.cgi?id=131196

Attachment 228567: Patch
https://bugs.webkit.org/attachment.cgi?id=228567&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228567&action=review


r=me with comments

> Source/WebCore/bindings/js/JSDOMWrapper.h:33
> +    JSNodeExtendedType = 0,

I'd say something like:

JSNodeType = ExtendedObjectType,

That way you don't have to remember to do the addition later, and you don't
have to keep typing "Extended" everywhere :-)