[webkit-reviews] review requested: [Bug 131115] prepare-Changelog and svn-create-patch should optionally run check-webkit-style. : [Attachment 228562] patch

[bugzilla-daemon at webkit.org]

James Craig <jcraig at apple.com> has asked  for review:
Bug 131115: prepare-Changelog and svn-create-patch should optionally run
check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=131115

Attachment 228562: patch
https://bugs.webkit.org/attachment.cgi?id=228562&action=review

------- Additional Comments from James Craig <jcraig at apple.com>
Added as default to prepare-Changelog, but couldn't figure out a good way to
set as default in svn-create-patch without causing a loop. Lots of scripts call
svn-create-patch, including check-webkit-style indirectly which causes a loop.
Most of the time these are system calls instead of submodules (probably b/c the
scripts are a mix of Python and Perl), so I could not use the "unless (caller)"
conditional reliably. Seems fine to me to make it a flag. I just set up a bash
alias for svn-create-patch to use the --style flag. I added --no-style in a few
of the callers, too.