[webkit-reviews] review granted: [Bug 131186] Web Inspector: JSContext inspection provide a way to opt-out of including Native Call Stacks in Exception traces reported to Web Inspector : [Attachment 228552] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 131186: Web Inspector: JSContext inspection provide a way to opt-out of
including Native Call Stacks in Exception traces reported to Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=131186

Attachment 228552: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=228552&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228552&action=review


r=me

> Source/JavaScriptCore/API/JSContextPrivate.h:46
> + at property
> + at discussion Set whether or not the native call stack is included when
reporting exceptions. Default value is YES.
> +*/
> + at property (setter=_setIncludeNativeCallStackWhenReportingExceptions:) BOOL
_includeNativeCallStackWhenReportingExceptions NS_AVAILABLE(10_10, 8_0);
> +

I think the preferred terminology when it comes to verbs is the infinitive:
"setIncludes" instead of "setInclude".

c.f.

– autosaves
– setAutosaves:

– setSuppressesIncrementalRendering:
– suppressesIncrementalRendering