[webkit-reviews] review granted: [Bug 131180] Merge ShapeInfo & ShapeOutsideInfo now that ShapeInsideInfo is no more : [Attachment 228545] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 3 15:06:48 PDT 2014


Andreas Kling <akling at apple.com> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 131180: Merge ShapeInfo & ShapeOutsideInfo now that ShapeInsideInfo is no
more
https://bugs.webkit.org/show_bug.cgi?id=131180

Attachment 228545: Patch
https://bugs.webkit.org/attachment.cgi?id=228545&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228545&action=review


r=me

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.h:93
> +	   InfoMap::AddResult result = infoMap.add(&key,
std::make_unique<ShapeOutsideInfo>(key));

I'd use "auto" here.


More information about the webkit-reviews mailing list