[webkit-reviews] review granted: [Bug 131141] [iOS][WK2] Add SPI to handle animated resize : [Attachment 228453] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 131141: [iOS][WK2] Add SPI to handle animated resize
https://bugs.webkit.org/show_bug.cgi?id=131141

Attachment 228453: Patch
https://bugs.webkit.org/attachment.cgi?id=228453&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228453&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:181
> +    [self _frameOrBoundsChangedFrom:self.bounds];

This is a bit weird. Maybe from:CGZeroRect?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:447
> +    // FIXME: animated resize is gonna be a lot of fun. Some properties need
to be updated live, others need to be stored
> +    // for the end of the animation.

I don't think this comment is useful.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:683
> +	   CGFloat oldWebViewWidhtInContentCoordinate = oldBounds.size.width /
contentZoomScale(self);

"Widht". Coordinates.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:686
> +	   CGFloat visibleWebPageWidthInContentCoordinate =
std::min([_contentView bounds].size.width, oldWebViewWidhtInContentCoordinate);

> +	   CGFloat targetScale = bounds.size.width /
visibleWebPageWidthInContentCoordinate;
> +	   [_scrollView setZoomScale:targetScale];

I'm not really sure what you're trying to do here.