[webkit-reviews] review granted: [Bug 131138] Document WKNavigationAction and WKNavigationResponse : [Attachment 228441] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 3 10:58:22 PDT 2014


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 131138: Document WKNavigationAction and WKNavigationResponse
https://bugs.webkit.org/show_bug.cgi?id=131138

Attachment 228441: Patch
https://bugs.webkit.org/attachment.cgi?id=228441&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228441&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h:38
> +/*! @abstract Whether the frame is the main frame or a subframe

Needs a period.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.h:40
> + @constant WebNavigationTypeOther	       Navigation is taking place for
some other reason.

WebNavigationTypeOther -> WKNavigationTypeOther


More information about the webkit-reviews mailing list