[webkit-reviews] review denied: [Bug 130834] Move UseJSC.cmake back to CMakeLists.txt : [Attachment 227943] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonác <ossy at webkit.org> has denied Éva Balázsfalvi
<evab.u-szeged at partner.samsung.com>'s request for review:
Bug 130834: Move UseJSC.cmake back to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=130834

Attachment 227943: Patch
https://bugs.webkit.org/attachment.cgi?id=227943&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227943&action=review


I agree with this change, but r- now due to some minor things.

> Source/WebCore/CMakeLists.txt:2838
> +    list(APPEND WebCore_SOURCES
> +	   bindings/js/JSCustomSQLStatementErrorCallback.cpp
> +	   bindings/js/JSSQLResultSetRowListCustom.cpp
> +	   bindings/js/JSSQLTransactionCustom.cpp
> +	   bindings/js/JSSQLTransactionSyncCustom.cpp
> +    )

Please move them after Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp -
few lines above.

> Source/WebCore/CMakeLists.txt:2875
> +	   bindings/js/JSWebGLRenderingContextCustom.cpp

We don't need one more APPEND, just add it before
html/canvas/ANGLEInstancedArrays.cpp.

> Source/WebCore/CMakeLists.txt:2976
> +	   bindings/js/JSAudioTrackCustom.cpp
> +	   bindings/js/JSAudioTrackListCustom.cpp
> +	   bindings/js/JSTextTrackCueCustom.cpp
> +	   bindings/js/JSTextTrackCustom.cpp
> +	   bindings/js/JSTextTrackListCustom.cpp
> +	   bindings/js/JSTrackCustom.cpp
> +	   bindings/js/JSTrackEventCustom.cpp
> +	   bindings/js/JSVideoTrackCustom.cpp
> +	   bindings/js/JSVideoTrackListCustom.cpp
> +    )
> +
> +    list(APPEND WebCore_SOURCES

ditto, just add them before html/track/AudioTrack.cpp

> Source/WebCore/CMakeLists.txt:-3193
> -
> -include(${WEBCORE_DIR}/UseJSC.cmake)
> -

I prefer moving the line 285 - end part of UseJSC.cmake
to this place instead of splitting into several pieces.