[webkit-reviews] review granted: [Bug 131118] Let's benchmark malloc : [Attachment 228412] patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 131118: Let's benchmark malloc
https://bugs.webkit.org/show_bug.cgi?id=131118

Attachment 228412: patch
https://bugs.webkit.org/attachment.cgi?id=228412&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228412&action=review


r=me with questions

> PerformanceTests/MallocBench/MallocBench/CPUCount.cpp:34
> +size_t cpuCount()

Don't we have something in WTF already that computes how many cores you have?

> PerformanceTests/MallocBench/MallocBench/facebook.cpp:49
> +    Interpreter interpreter("facebook.ops");

Is there a way to record these binary files for arbitrary workloads?

> PerformanceTests/MallocBench/MallocBench/realloc.cpp:34
> +void benchmark_realloc(bool isParallel)
> +{
> +}

Is this supposed to do anything yet?