[webkit-reviews] review denied: [Bug 131094] Remove one of the CSSProperty constructor : [Attachment 228373] Proposed patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has denied Zsolt Borbely
<zsborbely.u-szeged at partner.samsung.com>'s request for review:
Bug 131094: Remove one of the CSSProperty constructor
https://bugs.webkit.org/show_bug.cgi?id=131094

Attachment 228373: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=228373&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228373&action=review


> Source/WebCore/css/StyleProperties.h:78
> -	   CSSProperty toCSSProperty() const { return
CSSProperty(propertyMetadata(), const_cast<CSSValue*>(propertyValue())); }
> +	   CSSProperty toCSSProperty() const { return CSSProperty(id(),
const_cast<CSSValue*>(propertyValue())); }

Many test failures here.
CSSProperty(id, value) is not the same as CSSProperty(metadata, value).