[webkit-reviews] review denied: [Bug 131093] Move removeEquivalentProperties functions to EditingStyle : [Attachment 228370] Proposed patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has denied Zsolt Borbely
<zsborbely.u-szeged at partner.samsung.com>'s request for review:
Bug 131093: Move removeEquivalentProperties functions to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=131093

Attachment 228370: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=228370&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228370&action=review


Many test failures here.

> Source/WebCore/editing/EditingStyle.cpp:1576
> -    result->removeEquivalentProperties(baseStyle);
> +    RefPtr<EditingStyle> style = EditingStyle::create()->copy();
> +    style->removeEquivalentProperties(baseStyle);

Where's this data supposed to go?