[webkit-reviews] review granted: [Bug 131095] [GTK][CMake] Look for glx.h in OPENGL_INCLUDE_DIR. : [Attachment 228372] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Raphael Kubo da Costa
(:rakuco) <rakuco at webkit.org>'s request for review:
Bug 131095: [GTK][CMake] Look for glx.h in OPENGL_INCLUDE_DIR.
https://bugs.webkit.org/show_bug.cgi?id=131095

Attachment 228372: Patch
https://bugs.webkit.org/attachment.cgi?id=228372&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228372&action=review


> Source/cmake/OptionsGTK.cmake:231
> +set(_required_includes_old ${CMAKE_REQUIRED_INCLUDES})

Why do you use the macro naming scheme here? I think this can be
old_required_includes or OLD_REQUIRED_INCLUDES.