[webkit-reviews] review granted: [Bug 131088] [iOS] Remove the legacy string drawing code : [Attachment 228360] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 1 23:06:49 PDT 2014


Sam Weinig <sam at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 131088: [iOS] Remove the legacy string drawing code
https://bugs.webkit.org/show_bug.cgi?id=131088

Attachment 228360: Patch
https://bugs.webkit.org/attachment.cgi?id=228360&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228360&action=review


Yay!

> Source/WebKit/mac/Configurations/WebKit.xcconfig:30
> +EXCLUDED_SOURCE_FILE_NAMES_macosx = *IOS.mm MemoryMeasure.h
WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h
WebFrameIPhone.h WebGeolocationCoreLocationProvider.h WebGeolocationPrivate.h
WebGeolocationProviderIOS.h WebMIMETypeRegistry.h ebNSStringExtrasIOS.h
WebNSStringExtrasIPhone.h WebPDFViewIOS.h WebPDFViewIPhone.h
WebPDFViewPlaceholder.h WebSelectionRect.h WebUIKitDelegate.h WebUIKitSupport.h
WebVisiblePosition.h;

I think you removed an extra W. ebNSStringExtrasIOS.h should be
WebNSStringExtrasIOS.h.


More information about the webkit-reviews mailing list