[webkit-reviews] review granted: [Bug 131071] willReveal edge events should be hooked up for overflow:scroll : [Attachment 228330] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Beth Dakin <bdakin at apple.com>'s request
for review:
Bug 131071: willReveal edge events should be hooked up for overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=131071

Attachment 228330: Patch
https://bugs.webkit.org/attachment.cgi?id=228330&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228330&action=review


> Source/WebCore/dom/Document.cpp:5618
> +	// For each edge (top, bottom, left and right), send the will reveal
edge event for that direction

You have an extra space here.

> Source/WebCore/dom/Document.h:1177
> +    void sendWillRevealEdgeEventsIfNeeded(const IntPoint& oldPosition, const
IntPoint& newPosition, const IntRect& visibleRect, const IntSize& contentsSize,
Element* target = 0);

You should use Element* target = nullptr.  I would also rename this to
enqueueWillRevealEdgeEventsIfNeeded.  This might also be better on the
DocumentEventQueue class, not sure.