[webkit-reviews] review denied: [Bug 130391] [EFL] [WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set : [Attachment 228294] proposed patch 3

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Andrzej Badowski
<a.badowski at samsung.com>'s request for review:
Bug 130391: [EFL] [WK2] Replacing zoom functionality of MiniBrowser from
scale_set to page_zoom_set
https://bugs.webkit.org/show_bug.cgi?id=130391

Attachment 228294: proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=228294&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228294&action=review


> Source/WebKit2/ChangeLog:7
> +

Missing patch description.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:583
> +EAPI Eina_Bool ewk_view_page_zoom_set(Evas_Object *o, double zoomFactor);

Wrong EFL parameter style. Look at
https://trac.webkit.org/wiki/EFLWebKitCodingStyle

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1102
> ++

Remove +

> Tools/ChangeLog:7
> +

ditto.