[webkit-reviews] review granted: [Bug 131045] filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang : [Attachment 228298] Patch v3

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 131045: filter-build-webkit: Ignore xcodebuild warnings when compiling with
newer builds of clang
https://bugs.webkit.org/show_bug.cgi?id=131045

Attachment 228298: Patch v3
https://bugs.webkit.org/attachment.cgi?id=228298&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228298&action=review


> Tools/ChangeLog:10
> +	   (shouldIgnoreLine): Ignore DVTAssertions related to new builds
> +	   of clang.

This description may not fully represent the impact of the proposed change.
That is, we may also ignore the error details of any Xcode warning. See my
remark below for more details.

> Tools/Scripts/filter-build-webkit:261
> +    return 1 if $line =~ /^(Details|Object|Method|Function|Thread):/;
> +    return 1 if $line =~ /^Please file a bug at /;

Are these lines only emitted for DVTAssertions? If not, then we'll be omitting
these lines from all Xcode errors. (Is that OK?) We may want to consider
omitting these lines for only DVTAssertions.