[webkit-reviews] review granted: [Bug 130951] Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running : [Attachment 228139] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 130951: Move slow JSRegress tests out of the way so that they don't show up
in run-jsc-benchmarks runs and also skip tests that are extremely long-running
https://bugs.webkit.org/show_bug.cgi?id=130951

Attachment 228139: the patch
https://bugs.webkit.org/attachment.cgi?id=228139&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228139&action=review


>> Tools/ChangeLog:3
>> +	    Move slow JSRegress tests out of the way so that they don't show up
in run-jsc-benchmarks runs and also skip tests that are extremely long-running
> 
> I haven't find this run-jsc-benchmarks script in WebKit trunk and any test
skipping 
> in this patch. Referencing to an Apple internal script in the changelog is
confusing.

"//@ skip" skips a test.

I wonder, why isn't the run-jsc-benchmarks script open source?