[webkit-reviews] review granted: [Bug 131050] Web Inspector: Provide a way for JSContext console to log to system console : [Attachment 228304] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 131050: Web Inspector: Provide a way for JSContext console to log to system
console
https://bugs.webkit.org/show_bug.cgi?id=131050

Attachment 228304: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=228304&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228304&action=review


> Source/JavaScriptCore/inspector/JSConsoleClient.cpp:62
> +    Boolean preference =
CFPreferencesGetAppBooleanValue(CFSTR("JavaScriptCoreConsoleLogToSystemConsole"
), kCFPreferencesCurrentApplication, &keyExistsAndHasValidFormat);

JavaScriptCoreConsoleLogToSystemConsole implies only console.log is printed. A
verb like "output" would help too. Maybe:
OutputJavaScriptCoreConsoleToSystemConsole. Does this work for WebKit too?
Maybe OutputJavaScriptConsoleToSystemConsole if so.

> Source/JavaScriptCore/inspector/JSConsoleClient.cpp:82
> +    if (JSConsoleClient::logToSystemConsole())

No need for JSConsoleClient:: right?