[webkit-reviews] review denied: [Bug 130966] Implement Array.prototype.find() : [Attachment 228259] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 130966: Implement Array.prototype.find()
https://bugs.webkit.org/show_bug.cgi?id=130966

Attachment 228259: Patch
https://bugs.webkit.org/attachment.cgi?id=228259&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Please add tests for 0 vs undefined vs false vs null vs "" -- we want tests
that cover the specific kind of equality.  Also perf numbers relative to v8 and
SM would be good.

Test cases for array modification during search, 

Both test cases need to be bigger and should be using the shouldBe()
shouldBeTrue(), etc functions.	In general js/regress is for performancy tests
where we're trying to measure speed and jit behaviour.	and they use throw on
incorrect result as they need to ensure that the jit's don't DCE the entire
test.

So r-, you need more tests.  I suspect the filter, etc tests in js/ should give
a good example of expected behaviour.