[webkit-reviews] review granted: [Bug 129687] [Mac][WK2] Videos do not have access to session cookies : [Attachment 228221] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 1 09:10:27 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 129687: [Mac][WK2] Videos do not have access to session cookies
https://bugs.webkit.org/show_bug.cgi?id=129687

Attachment 228221: Patch
https://bugs.webkit.org/attachment.cgi?id=228221&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228221&action=review


> Source/WebKit2/Shared/mac/CookieStorageShim.mm:116
> +    dispatch_async(dispatch_get_main_queue(), ^{
> +	  
completionHandler(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL(null
ptr, (CFURLRef)[[task currentRequest] URL]));

Can completionHandler be NULL?


More information about the webkit-reviews mailing list