[webkit-reviews] review requested: [Bug 118343] [WK2][Soup] Support cache model in NetworkProcess : [Attachment 213006] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 30 09:42:35 PDT 2013
Csaba Osztrogonac <ossy at webkit.org> has asked for review:
Bug 118343: [WK2][Soup] Support cache model in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=118343
Attachment 213006: patch
https://bugs.webkit.org/attachment.cgi?id=213006&action=review
------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
(In reply to comment #2)
> (From update of attachment 205980 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=205980&action=review
>
> > Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:81
> > + g_object_set(session, SOUP_SESSION_SSL_USE_SYSTEM_CA_FILE, TRUE,
> > + SOUP_SESSION_SSL_STRICT, FALSE, 0);
>
> The last argument of g_object_set should be NULL instead of 0. Otherwise, the
compiler warns "missing sentinel in function call [-Wformat]"
Fixed this warning too.
More information about the webkit-reviews
mailing list