[webkit-reviews] review granted: [Bug 122049] REGRESSION(r156546): media/video-no-audio.html broken : [Attachment 212877] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 122049: REGRESSION(r156546): media/video-no-audio.html broken
https://bugs.webkit.org/show_bug.cgi?id=122049

Attachment 212877: Patch
https://bugs.webkit.org/attachment.cgi?id=212877&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212877&action=review


> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:474
> +    handleAudioTrackChange: function(event)
> +    {
> +	   this.updateHasAudio();
> +    },
> +
> +    handleAudioTrackAdd: function(event)
> +    {
> +	   this.updateHasAudio();
> +    },
> +
> +    handleAudioTrackRemove: function(event)
> +    {
> +	   this.updateHasAudio();
> +    },

Why not have a singe event handler for all three events, so each of these does
the same thing?