[webkit-reviews] review requested: [Bug 122015] [ATK] Expose aria-invalid as a text attribute (not object attribute) : [Attachment 212986] Patch proposal
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 30 06:04:22 PDT 2013
Mario Sanchez Prada <mario at webkit.org> has asked for review:
Bug 122015: [ATK] Expose aria-invalid as a text attribute (not object
attribute)
https://bugs.webkit.org/show_bug.cgi?id=122015
Attachment 212986: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=212986&action=review
------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Sorry for the spam but I'm attaching a new version of the previous patch now
that I think it's cleaner and more easy to scale, as I put all the attributes
related mappings between ATK and layout tests inside a bidimensional array.
Also the code in coreAttributeToAtkAttribute() is cleaner too.
We probably should do something similar to simplify the roleToString() funcion,
me thinks...
More information about the webkit-reviews
mailing list